Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 309483015: Add trace events for PPB audio callbacks. (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add trace events for PPB audio callbacks. BUG=336096 TEST=Play audio. Run trace. Observe entries. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ppapi/shared_impl/ppb_audio_shared.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
This mirrors the trace event we have for non-PPAPI audio clients: https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/audio_output_device.cc&l=296
6 years, 6 months ago (2014-06-02 19:26:21 UTC) #1
dmichael (off chromium)
lgtm
6 years, 6 months ago (2014-06-02 21:05:32 UTC) #2
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-06-02 21:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/309483015/1
6 years, 6 months ago (2014-06-02 21:16:23 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 01:05:13 UTC) #5
Message was sent while issue was closed.
Change committed as 274397

Powered by Google App Engine
This is Rietveld 408576698