Issue 309483012: Revert 273982 "Refactor external_install_ui"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309483012: Revert 273982 "Refactor external_install_ui" (Closed)

Created:
6 years, 6 months ago by dxie1

Modified:
6 years, 6 months ago

Reviewers:
Devlin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 273982 "Refactor external_install_ui" Referring to https://code.google.com/p/chromium/issues/detail?id=379470, This is causing significant stability on trunk. reverting. > Refactor external_install_ui > > Refactors ExternalInstallUI to have determinate lifetimes. > This is likely the first of multiple patches targeting this area of code; the > next one will concentrate on pulling the related logic out of ExtensionService. > > BUG=378042 > > Review URL: https://codereview.chromium.org/300853008 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274103

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -726 lines)			Patch
M	trunk/src/chrome/browser/extensions/extension_service.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_service.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_service_unittest.cc	View	10 chunks	+18 lines, -24 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/external_install_error.h	View	1 chunk	+0 lines, -124 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/external_install_error.cc	View	1 chunk	+0 lines, -384 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/external_install_manager.h	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/external_install_manager.cc	View	1 chunk	+0 lines, -100 lines	0 comments	Download
A +	trunk/src/chrome/browser/extensions/external_install_ui.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/extensions/external_install_ui.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

dxie1

6 years, 6 months ago (2014-06-01 02:17:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r274103 (tree was closed).