Issue 309483008: Files.app: Retrieve disk label name from mount path.

Issue 309483008: Files.app: Retrieve disk label name from mount path. (Closed)

Created:
6 years, 6 months ago by kinaba

Modified:
6 years, 6 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files.app: Retrieve disk label name from mount path. As it was before r272170. BUG=378879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273815

Patch Set 2 : Fix test #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/file_manager/volume_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/test/data/extensions/api_test/file_browser/mount_test/test.js	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

kinaba

PTAL. drive_label() looks, contrary to its name, to be inappropriate for our purpose... https://code.google.com/p/chromium/codesearch#chromium/src/chromeos/dbus/cros_disks_client.h&q=drive_label&sq=package:chromium&type=cs&l=146

6 years, 6 months ago (2014-05-30 04:15:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/309483008/1

6 years, 6 months ago (2014-05-30 05:28:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/309483008/20001

6 years, 6 months ago (2014-05-30 07:34:48 UTC) #7

Message was sent while issue was closed.

Change committed as 273815

Expand Messages | Collapse Messages