Issue 309483003: DM tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309483003: DM tweaks (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
hal.canary, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

DM tweaks - Don't print status updates for skipped tasks or count them as pending tasks. - Refactor DMReporter a bit for better symmetry, be more explicit about how we read atomics (that is, approximately) in printStatus() (née finish()). - Remove mutex locking from printStatus(). BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14977

Patch Set 1 #

Patch Set 2 : note #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -36 lines)			Patch
M	dm/DM.cpp	View		4 chunks	+7 lines, -9 lines	0 comments	Download
M	dm/DMReporter.h	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	dm/DMReporter.cpp	View	1	3 chunks	+9 lines, -12 lines	0 comments	Download
M	dm/DMTask.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMTask.cpp	View		4 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mtklein

I've been getting a little annoyed reading through logs like this one where we pass ...

6 years, 6 months ago (2014-05-29 14:14:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/309483003/20001

6 years, 6 months ago (2014-05-29 20:09:14 UTC) #4

Message was sent while issue was closed.

Change committed as 14977

Expand Messages | Collapse Messages