Source/core/inspector/InspectorOverlay.h - Issue 309473002: [DevTools] Cleanup inspector overlay and make it work with virtual viewport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorOverlay.h

Issue 309473002: [DevTools] Cleanup inspector overlay and make it work with virtual viewport. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorController.cpp ('k') | Source/core/inspector/InspectorOverlay.cpp » ('j') | Source/core/inspector/InspectorOverlay.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorOverlay.h

diff --git a/Source/core/inspector/InspectorOverlay.h b/Source/core/inspector/InspectorOverlay.h

index 579fcf67f51c897a019f7e2d3106a428936eda2a..49f989c6d8acd22bae2854c3db0e1d160f0961d4 100644

--- a/Source/core/inspector/InspectorOverlay.h

+++ b/Source/core/inspector/InspectorOverlay.h

@@ -121,7 +121,6 @@ public:

void hide();

void paint(GraphicsContext&);

void drawOutline(GraphicsContext*, const LayoutRect&, const Color&);

- void resize(const IntSize&);

bool handleGestureEvent(const PlatformGestureEvent&);

bool handleMouseEvent(const PlatformMouseEvent&);

bool handleTouchEvent(const PlatformTouchEvent&);

@@ -159,7 +158,7 @@ private:

void drawViewSize();

Page* overlayPage();

- void reset(const IntSize& viewportSize, const IntSize& frameViewFullSize, int scrollX, int scrollY);

+ void reset(const IntSize& viewportSize, int scrollX, int scrollY);

void evaluateInOverlay(const String& method, const String& argument);

void evaluateInOverlay(const String& method, PassRefPtr<JSONValue> argument);

void onTimer(Timer<InspectorOverlay>*);

@@ -176,7 +175,6 @@ private:

OwnPtr<EmptyChromeClient> m_overlayChromeClient;

RefPtr<InspectorOverlayHost> m_overlayHost;

HighlightConfig m_quadHighlightConfig;

- IntSize m_size;

bool m_drawViewSize;

bool m_drawViewSizeWithGrid;

bool m_omitTooltip;

« no previous file with comments | « Source/core/inspector/InspectorController.cpp ('k') | Source/core/inspector/InspectorOverlay.cpp » ('j') | Source/core/inspector/InspectorOverlay.cpp » ('J')