[DevTools] Cleanup inspector overlay and make it work with virtual viewport.

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1594 matching lines @@
 
     {
         // Avoids unnecessary invalidations while various bits of state in FastTextAutosizer are updated.
         FastTextAutosizer::DeferUpdatePageInfo deferUpdatePageInfo(page());
 
         m_pageScaleConstraintsSet.didChangeViewSize(m_size);
 
         updatePageDefinedViewportConstraints(mainFrameImpl()->frame()->document()->viewportDescription());
         updateMainFrameLayoutSize();
 
-        WebDevToolsAgentPrivate* agentPrivate = devToolsAgentPrivate();
-        if (agentPrivate)
-            agentPrivate->webViewResized(newSize);
-
         // If the virtual viewport pinch mode is enabled, the main frame will be resized
         // after layout so it can be sized to the contentsSize.
         if (!pinchVirtualViewportEnabled() && mainFrameImpl()->frameView())
             mainFrameImpl()->frameView()->resize(m_size);
 
         if (pinchVirtualViewportEnabled())
             page()->frameHost().pinchViewport().setSize(m_size);
     }
 
     if (settings()->viewportEnabled() && !m_fixedLayoutSizeLock) {
@@ skipping 1679 matching lines @@
 {
     if (!m_page)
         return;
 
     if (point.x == -1 || point.y == -1) {
         m_page->inspectorController().inspect(0);
     } else {
         HitTestRequest::HitTestRequestType hitType = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::AllowChildFrameContent;
         HitTestRequest request(hitType);
 
-        FrameView* frameView = m_page->mainFrame()->view();
-        IntPoint transformedPoint(point);
-        transformedPoint = transformedPoint - frameView->inputEventsOffsetForEmulation();
-        transformedPoint.scale(1 / frameView->inputEventsScaleFactor(), 1 / frameView->inputEventsScaleFactor());
+        WebMouseEvent dummyEvent;

[pfeldman, 2014/05/29 15:20:30]

Why do we have to do this?

[dgozman, 2014/05/29 15:28:37]

We want to hit exactly the same node as mouse event which caused context menu
did. There is a lot of logic in platform event builders, so it's better to reuse
it instead of following up with the changes.

+        dummyEvent.type = WebInputEvent::MouseDown;
+        dummyEvent.x = point.x;
+        dummyEvent.y = point.y;
+        IntPoint transformedPoint = PlatformMouseEventBuilder(m_page->mainFrame()->view(), dummyEvent).position();
         HitTestResult result(m_page->mainFrame()->view()->windowToContents(transformedPoint));
         m_page->mainFrame()->contentRenderer()->hitTest(request, result);
         Node* node = result.innerNode();
         if (!node && m_page->mainFrame()->document())
             node = m_page->mainFrame()->document()->documentElement();
         m_page->inspectorController().inspect(node);
     }
 }
 
 WebString WebViewImpl::inspectorSettings() const
@@ skipping 718 matching lines @@
     const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
 
     if (!mainFrameImpl() || !mainFrameImpl()->frameView())
         return false;
 
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace blink