Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: content/browser/service_worker/service_worker_provider_host_unittest.cc

Issue 309453002: ServiceWorker: Rename 'pending version' to 'installing' or 'waiting' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host_unittest.cc
diff --git a/content/browser/service_worker/service_worker_provider_host_unittest.cc b/content/browser/service_worker/service_worker_provider_host_unittest.cc
index 388e741e4a249d33d47f4f8fc47c651d78e58b26..df265756aae40e850563ecf21235383cbf6da2df 100644
--- a/content/browser/service_worker/service_worker_provider_host_unittest.cc
+++ b/content/browser/service_worker/service_worker_provider_host_unittest.cc
@@ -114,40 +114,40 @@ TEST_F(ServiceWorkerProviderHostTest,
ASSERT_FALSE(version_->HasProcessToRun());
}
-TEST_F(ServiceWorkerProviderHostTest, SetPendingVersion_ProcessStatus) {
+TEST_F(ServiceWorkerProviderHostTest, SetWaitingVersion_ProcessStatus) {
ASSERT_FALSE(version_->HasProcessToRun());
- // Associating version_ to a provider_host's pending version will internally
+ // Associating version_ to a provider_host's waiting version will internally
// add the provider_host's process ref to the version.
- provider_host1_->SetPendingVersion(version_);
+ provider_host1_->SetWaitingVersion(version_);
ASSERT_TRUE(version_->HasProcessToRun());
// Re-associating the same version and provider_host should just work too.
- provider_host1_->SetPendingVersion(version_);
+ provider_host1_->SetWaitingVersion(version_);
ASSERT_TRUE(version_->HasProcessToRun());
- // Resetting the provider_host's pending version should remove process refs
+ // Resetting the provider_host's waiting version should remove process refs
// from the version.
- provider_host1_->SetPendingVersion(NULL);
+ provider_host1_->SetWaitingVersion(NULL);
ASSERT_FALSE(version_->HasProcessToRun());
}
TEST_F(ServiceWorkerProviderHostTest,
- SetPendingVersion_MultipleHostsForSameProcess) {
+ SetWaitingVersion_MultipleHostsForSameProcess) {
ASSERT_FALSE(version_->HasProcessToRun());
// Associating version_ to two providers as active version.
- provider_host1_->SetPendingVersion(version_);
- provider_host2_->SetPendingVersion(version_);
+ provider_host1_->SetWaitingVersion(version_);
+ provider_host2_->SetWaitingVersion(version_);
ASSERT_TRUE(version_->HasProcessToRun());
// Disassociating one provider_host shouldn't remove all process refs
// from the version yet.
- provider_host1_->SetPendingVersion(NULL);
+ provider_host1_->SetWaitingVersion(NULL);
ASSERT_TRUE(version_->HasProcessToRun());
// Disassociating the other provider_host will remove all process refs.
- provider_host2_->SetPendingVersion(NULL);
+ provider_host2_->SetWaitingVersion(NULL);
ASSERT_FALSE(version_->HasProcessToRun());
}
@@ -177,18 +177,18 @@ class ServiceWorkerRegisterJobAndProviderHostTest
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegisterJobAndProviderHostTest);
};
-// Test for ServiceWorkerRegisterJob::AssociatePendingVersionToDocuments.
+// Test for ServiceWorkerRegisterJob::AssociateWaitingVersionToDocuments.
TEST_F(ServiceWorkerRegisterJobAndProviderHostTest,
- AssociatePendingVersionToDocuments) {
- register_job_->AssociatePendingVersionToDocuments(version_.get());
- EXPECT_EQ(version_.get(), provider_host1_->pending_version());
- EXPECT_EQ(version_.get(), provider_host2_->pending_version());
- EXPECT_EQ(NULL, provider_host3_->pending_version());
-
- register_job_->AssociatePendingVersionToDocuments(NULL);
- EXPECT_EQ(NULL, provider_host1_->pending_version());
- EXPECT_EQ(NULL, provider_host2_->pending_version());
- EXPECT_EQ(NULL, provider_host3_->pending_version());
+ AssociateWaitingVersionToDocuments) {
+ register_job_->AssociateWaitingVersionToDocuments(version_.get());
+ EXPECT_EQ(version_.get(), provider_host1_->waiting_version());
+ EXPECT_EQ(version_.get(), provider_host2_->waiting_version());
+ EXPECT_EQ(NULL, provider_host3_->waiting_version());
+
+ register_job_->AssociateWaitingVersionToDocuments(NULL);
+ EXPECT_EQ(NULL, provider_host1_->waiting_version());
+ EXPECT_EQ(NULL, provider_host2_->waiting_version());
+ EXPECT_EQ(NULL, provider_host3_->waiting_version());
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698