ServiceWorker: Rename 'pending version' to 'installing' or 'waiting'

content/browser/service_worker/service_worker_register_job.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTER_JOB_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTER_JOB_H_
 
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 40 matching lines @@
   // clients, a new RenderProcessHost will be created.
   void AddCallback(const RegistrationCallback& callback, int process_id);
 
   // ServiceWorkerRegisterJobBase implementation:
   virtual void Start() OVERRIDE;
   virtual bool Equals(ServiceWorkerRegisterJobBase* job) OVERRIDE;
   virtual RegistrationJobType GetType() OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerRegisterJobAndProviderHostTest,
-                           AssociatePendingVersionToDocuments);
+                           AssociateWaitingVersionToDocuments);
 
   enum Phase {
      INITIAL,
      START,
      REGISTER,
      UPDATE,
      INSTALL,
      STORE,
      ACTIVATE,
      COMPLETE
   };
 
   // Holds internal state of ServiceWorkerRegistrationJob, to compel use of the
   // getter/setter functions.
   struct Internal {
     Internal();
     ~Internal();
     scoped_refptr<ServiceWorkerRegistration> registration;
-    scoped_refptr<ServiceWorkerVersion> pending_version;
+    scoped_refptr<ServiceWorkerVersion> waiting_version;

[falken, 2014/05/29 07:23:34]

pending_version here doesn't necessarily correspond to the spec's "waiting"; it
can hold the spec's "installing" or "waiting" version. So I think it's better to
keep it as "pending" (we should have a comment saying such too)

[michaeln1, 2014/05/29 21:16:52]

+1 keeping this as "pending" (or something else thats not "installing" or
"waiting"). "pending", "inprogress", or "new".

[nhiroki, 2014/05/30 00:38:20]

Reverted this to 'pending' and added comment.

   };
 
   void set_registration(ServiceWorkerRegistration* registration);
   ServiceWorkerRegistration* registration();
-  void set_pending_version(ServiceWorkerVersion* version);
-  ServiceWorkerVersion* pending_version();
+  void set_waiting_version(ServiceWorkerVersion* version);
+  ServiceWorkerVersion* waiting_version();
 
   void SetPhase(Phase phase);
 
   void HandleExistingRegistrationAndContinue(
       ServiceWorkerStatusCode status,
       const scoped_refptr<ServiceWorkerRegistration>& registration);
   void RegisterAndContinue(ServiceWorkerStatusCode status);
   void UpdateAndContinue(ServiceWorkerStatusCode status);
   void OnStartWorkerFinished(ServiceWorkerStatusCode status);
   void OnStoreRegistrationComplete(ServiceWorkerStatusCode status);
   void InstallAndContinue();
   void OnInstallFinished(ServiceWorkerStatusCode status);
   void ActivateAndContinue();
   void OnActivateFinished(ServiceWorkerStatusCode status);
   void Complete(ServiceWorkerStatusCode status);
 
   void ResolvePromise(ServiceWorkerStatusCode status,
                       ServiceWorkerRegistration* registration,
                       ServiceWorkerVersion* version);
 
-  CONTENT_EXPORT void AssociatePendingVersionToDocuments(
+  CONTENT_EXPORT void AssociateWaitingVersionToDocuments(
       ServiceWorkerVersion* version);
 
   // The ServiceWorkerContextCore object should always outlive this.
   base::WeakPtr<ServiceWorkerContextCore> context_;
 
   const GURL pattern_;
   const GURL script_url_;
   std::vector<RegistrationCallback> callbacks_;
   std::vector<int> pending_process_ids_;
   Phase phase_;
   Internal internal_;
   bool is_promise_resolved_;
   ServiceWorkerStatusCode promise_resolved_status_;
   scoped_refptr<ServiceWorkerRegistration> promise_resolved_registration_;
   scoped_refptr<ServiceWorkerVersion> promise_resolved_version_;
   base::WeakPtrFactory<ServiceWorkerRegisterJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegisterJob);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTER_JOB_H_