Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309443002: Remove need to sign in to use the App Launcher. (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Remove need to sign in to use the App Launcher. TBR=sky@chromium.org BUG=378588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274486

Patch Set 1 #

Patch Set 2 : Removed include #

Patch Set 3 : Compile #

Total comments: 4

Patch Set 4 : Feedback #

Patch Set 5 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -940 lines) Patch
M ash/shell/app_list.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 5 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 7 chunks +1 line, -53 lines 1 comment Download
D chrome/browser/ui/app_list/chrome_signin_delegate.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/app_list/chrome_signin_delegate.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 4 chunks +0 lines, -7 lines 0 comments Download
M ui/app_list/app_list_menu.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ui/app_list/app_list_view_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/app_list/cocoa/app_list_view_controller.mm View 2 chunks +0 lines, -20 lines 0 comments Download
M ui/app_list/cocoa/app_list_view_controller_unittest.mm View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
D ui/app_list/cocoa/signin_view_controller.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/app_list/cocoa/signin_view_controller.mm View 1 chunk +0 lines, -200 lines 0 comments Download
D ui/app_list/cocoa/signin_view_controller_unittest.mm View 1 chunk +0 lines, -115 lines 0 comments Download
D ui/app_list/signin_delegate.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/app_list/signin_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.h View 1 2 3 4 4 chunks +0 lines, -7 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.cc View 1 2 3 4 2 chunks +0 lines, -45 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 2 3 7 chunks +1 line, -20 lines 0 comments Download
D ui/app_list/views/signin_view.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/app_list/views/signin_view.cc View 1 chunk +0 lines, -138 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
benwells
6 years, 6 months ago (2014-05-30 06:36:45 UTC) #1
calamity
https://codereview.chromium.org/309443002/diff/30001/ui/app_list/views/app_list_view.cc File ui/app_list/views/app_list_view.cc (left): https://codereview.chromium.org/309443002/diff/30001/ui/app_list/views/app_list_view.cc#oldcode151 ui/app_list/views/app_list_view.cc:151: signin_view_(NULL), This file needs corresponding changes to the header. ...
6 years, 6 months ago (2014-06-02 04:36:15 UTC) #2
benwells
https://codereview.chromium.org/309443002/diff/30001/ui/app_list/views/app_list_view.cc File ui/app_list/views/app_list_view.cc (left): https://codereview.chromium.org/309443002/diff/30001/ui/app_list/views/app_list_view.cc#oldcode151 ui/app_list/views/app_list_view.cc:151: signin_view_(NULL), On 2014/06/02 04:36:15, calamity wrote: > This file ...
6 years, 6 months ago (2014-06-02 07:48:55 UTC) #3
calamity
lgtm
6 years, 6 months ago (2014-06-03 02:45:53 UTC) #4
benwells
+tbr sky for fallout in ash
6 years, 6 months ago (2014-06-03 02:58:39 UTC) #5
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-03 02:58:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/309443002/70001
6 years, 6 months ago (2014-06-03 03:01:02 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 07:10:22 UTC) #8
tapted
(drive-by - sorry meant to look at this sooner, but these are probably fine for ...
6 years, 6 months ago (2014-06-03 08:41:01 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:40:10 UTC) #10
Message was sent while issue was closed. 
Change committed as 274486

Powered by Google App Engine
This is Rietveld 408576698