Issue 309403002: Adding image resources for the new security interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309403002: Adding image resources for the new security interstitials (Closed)

Created:
6 years, 6 months ago by felt

Modified:
6 years, 6 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding image resources for the new security interstitials BUG=331453, 380238 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274562

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)		Patch
A	chrome/browser/resources/safe_browsing/images/1x/stop_sign.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/2x/stop_sign.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/ssl/images/1x/brokenssl_red.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/ssl/images/1x/brokenssl_white.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/ssl/images/2x/brokenssl_red.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/ssl/images/2x/brokenssl_white.png	View	Binary file	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

felt

Hi Bernhard, TBRing you on the addition of the new binary image files that UX ...

6 years, 6 months ago (2014-06-03 17:22:31 UTC) #1

felt

Committed patchset #1 manually as r274562 (presubmit successful).

6 years, 6 months ago (2014-06-03 17:27:59 UTC) #2

felt

On 2014/06/03 17:27:59, felt wrote: > Committed patchset #1 manually as r274562 (presubmit successful). dcommit ...

6 years, 6 months ago (2014-06-03 17:30:05 UTC) #3

felt

6 years, 6 months ago (2014-06-03 17:32:27 UTC) #4

On 2014/06/03 17:30:05, felt wrote:
> On 2014/06/03 17:27:59, felt wrote:
> > Committed patchset #1 manually as r274562 (presubmit successful).
> 
> dcommit failed, that revision didn't actually stick.

apparently the error was a lie, it did commit.

Expand Messages | Collapse Messages