Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 309393002: [CSS Grid Layout] Add 'auto' fallback for non existent named grid lines (Closed)

Created:
6 years, 6 months ago by svillar
Modified:
6 years, 6 months ago
CC:
blink-reviews, jfernandez, blink-reviews-rendering, zoltan1, svillar, Manuel Rego, leviw+renderwatch, eae+blinkwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

This is a follow up of r174021 where we added support for placing grid items using named grid lines. We left unfixed the case of the author using non existent named grid lines. The truth is that it was already partially fixed by some previous changes. Instead of forcing resolveGridPositionFromStyle() to return a non resolved grid position (like 'auto') we try to detect the usage of a non existent named grid line before trying to resolve the grid position. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176022

Patch Set 1 #

Patch Set 2 : Minor refactoring #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M Source/core/rendering/style/GridResolvedPosition.cpp View 1 2 4 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
svillar
I am not adding any additional test case because we're already covered by existing tests. ...
6 years, 6 months ago (2014-06-04 15:17:53 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/309393002/diff/20001/Source/core/rendering/style/GridResolvedPosition.cpp File Source/core/rendering/style/GridResolvedPosition.cpp (right): https://codereview.chromium.org/309393002/diff/20001/Source/core/rendering/style/GridResolvedPosition.cpp#newcode25 Source/core/rendering/style/GridResolvedPosition.cpp:25: static inline const String implicitNamedGridLineForSide(const String& lineName, GridPositionSide ...
6 years, 6 months ago (2014-06-11 22:24:14 UTC) #2
svillar
The CQ bit was checked by svillar@igalia.com
6 years, 6 months ago (2014-06-12 10:25:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/309393002/40001
6 years, 6 months ago (2014-06-12 10:26:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 11:30:55 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:26:41 UTC) #6
Message was sent while issue was closed.
Change committed as 176022

Powered by Google App Engine
This is Rietveld 408576698