Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 309353003: Null check the render layer as it might be gone when video enters/exits fullscreen (Closed)

Created:
6 years, 6 months ago by qinmin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Null check the render layer as it might be gone when video enters/exits fullscreen The delegated render layer can change when video enters/exits fullscreen Similar to other places in this file where layer_ is used, we should do a null check before using it. BUG=356671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
qinmin
PTAL
6 years, 6 months ago (2014-06-03 19:29:04 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 6 months ago (2014-06-03 19:41:44 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 6 months ago (2014-06-03 20:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/309353003/1
6 years, 6 months ago (2014-06-03 20:19:10 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 00:09:49 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:16:53 UTC) #6
Message was sent while issue was closed.
Change committed as 274741

Powered by Google App Engine
This is Rietveld 408576698