Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309343004: Add LICENSE & README.google files to third_party/etc1 (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add LICENSE & README.google files to third_party/etc1 Committed: https://skia.googlesource.com/skia/+/8a35140f3fbc0937b969e6f3356b83ee756ce065

Patch Set 1 #

Patch Set 2 : Reattaching to CL #

Total comments: 2

Patch Set 3 : Fixed README file #

Patch Set 4 : Added SHA #

Patch Set 5 : added SHA #

Total comments: 2

Patch Set 6 : Fix description field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
A third_party/etc1/LICENSE View 1 1 chunk +161 lines, -0 lines 0 comments Download
A third_party/etc1/README.google View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-03 18:29:41 UTC) #1
djsollen
https://codereview.chromium.org/309343004/diff/20001/third_party/etc1/README.google File third_party/etc1/README.google (right): https://codereview.chromium.org/309343004/diff/20001/third_party/etc1/README.google#newcode2 third_party/etc1/README.google:2: Version: XXX # e.g., version string of the package, ...
6 years, 6 months ago (2014-06-03 18:50:44 UTC) #2
robertphillips
https://codereview.chromium.org/309343004/diff/20001/third_party/etc1/README.google File third_party/etc1/README.google (right): https://codereview.chromium.org/309343004/diff/20001/third_party/etc1/README.google#newcode2 third_party/etc1/README.google:2: Version: XXX # e.g., version string of the package, ...
6 years, 6 months ago (2014-06-03 18:59:49 UTC) #3
krajcevski
lgtm + small nit https://codereview.chromium.org/309343004/diff/80001/third_party/etc1/README.google File third_party/etc1/README.google (right): https://codereview.chromium.org/309343004/diff/80001/third_party/etc1/README.google#newcode5 third_party/etc1/README.google:5: Description: ETC1 file format support ...
6 years, 6 months ago (2014-06-03 19:01:58 UTC) #4
djsollen
lgtm
6 years, 6 months ago (2014-06-03 19:11:50 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-03 19:19:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/309343004/100001
6 years, 6 months ago (2014-06-03 19:19:43 UTC) #7
robertphillips
https://codereview.chromium.org/309343004/diff/80001/third_party/etc1/README.google File third_party/etc1/README.google (right): https://codereview.chromium.org/309343004/diff/80001/third_party/etc1/README.google#newcode5 third_party/etc1/README.google:5: Description: ETC1 file format support On 2014/06/03 19:01:58, krajcevski ...
6 years, 6 months ago (2014-06-03 19:19:57 UTC) #8
robertphillips
6 years, 6 months ago (2014-06-03 19:21:51 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:31:12 UTC) #10
Message was sent while issue was closed. 
Change committed as 8a35140f3fbc0937b969e6f3356b83ee756ce065

Powered by Google App Engine
This is Rietveld 408576698