Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 309293002: Changed keyboard shortcut for touch projector overlay from Ctrl-Shift-9 to Ctrl-Alt-P (Closed)

Created:
6 years, 6 months ago by mkaeser
Modified:
6 years, 6 months ago
Reviewers:
stevenjb, mohsen, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, mazda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changed keyboard shortcut for touch projector overlay from Ctrl-Shift-9 to Ctrl-Alt-P. The Ctrl-Shift-9 combination is used by Gmail to change formatting. Ctrl-Alt-P seems to be a viable alternative based on the discussion in the bug. BUG=307661 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276726

Patch Set 1 #

Patch Set 2 : Fix typo in shortcut #

Total comments: 2

Patch Set 3 : List modifiers in alphabetical order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/accelerators/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
mkaeser
The CQ bit was checked by mkaeser@google.com
6 years, 6 months ago (2014-06-03 17:59:56 UTC) #1
mkaeser
The CQ bit was unchecked by mkaeser@google.com
6 years, 6 months ago (2014-06-03 17:59:57 UTC) #2
mkaeser
6 years, 6 months ago (2014-06-03 18:09:45 UTC) #3
mohsen
https://codereview.chromium.org/309293002/diff/20001/chrome/browser/resources/chromeos/keyboard_overlay_data.js File chrome/browser/resources/chromeos/keyboard_overlay_data.js (right): https://codereview.chromium.org/309293002/diff/20001/chrome/browser/resources/chromeos/keyboard_overlay_data.js#newcode15881 chrome/browser/resources/chromeos/keyboard_overlay_data.js:15881: 'p<>CTRL<>ALT': 'keyboardOverlayToggleProjectionTouchHud', This does not show the shortcut in ...
6 years, 6 months ago (2014-06-03 19:36:17 UTC) #4
mkaeser
Thanks, PTAL. https://codereview.chromium.org/309293002/diff/20001/chrome/browser/resources/chromeos/keyboard_overlay_data.js File chrome/browser/resources/chromeos/keyboard_overlay_data.js (right): https://codereview.chromium.org/309293002/diff/20001/chrome/browser/resources/chromeos/keyboard_overlay_data.js#newcode15881 chrome/browser/resources/chromeos/keyboard_overlay_data.js:15881: 'p<>CTRL<>ALT': 'keyboardOverlayToggleProjectionTouchHud', On 2014/06/03 19:36:17, mohsen wrote: ...
6 years, 6 months ago (2014-06-04 07:59:03 UTC) #5
mohsen
On 2014/06/04 07:59:03, mkaeser wrote: > Thanks, PTAL. > > https://codereview.chromium.org/309293002/diff/20001/chrome/browser/resources/chromeos/keyboard_overlay_data.js > File chrome/browser/resources/chromeos/keyboard_overlay_data.js (right): ...
6 years, 6 months ago (2014-06-04 13:25:49 UTC) #6
mkaeser
On 2014/06/04 13:25:49, mohsen wrote: > On 2014/06/04 07:59:03, mkaeser wrote: > > Thanks, PTAL. ...
6 years, 6 months ago (2014-06-04 13:29:14 UTC) #7
mohsen
You need an OWNER reviewer; I'm not an OWNER. Adding sky@ as an OWNER...
6 years, 6 months ago (2014-06-04 13:57:49 UTC) #8
sky
I don't see an approval on the bug for this change. Did someone from UX ...
6 years, 6 months ago (2014-06-04 15:51:28 UTC) #9
mkaeser
On 2014/06/04 15:51:28, sky wrote: > I don't see an approval on the bug for ...
6 years, 6 months ago (2014-06-04 15:59:09 UTC) #10
sky
I sent email and cc'd you on it. -Scott On Wed, Jun 4, 2014 at ...
6 years, 6 months ago (2014-06-04 19:25:25 UTC) #11
sky
LGTM
6 years, 6 months ago (2014-06-04 23:07:08 UTC) #12
mkaeser
The CQ bit was checked by mkaeser@google.com
6 years, 6 months ago (2014-06-12 12:05:35 UTC) #13
mkaeser
Thanks for the approval! As far as I know, I cannot submit this myself as ...
6 years, 6 months ago (2014-06-12 12:06:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkaeser@google.com/309293002/40001
6 years, 6 months ago (2014-06-12 12:08:10 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 17:21:28 UTC) #16
Message was sent while issue was closed.
Change committed as 276726

Powered by Google App Engine
This is Rietveld 408576698