Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 309283002: Oilpan: convert remaining editing/ RefPtr<Node>s to transition types. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: convert remaining editing/ RefPtr<Node>s to transition types. Remove unnecessary uses of RefPtr<Node>s with Oilpan enabled. R=zerny@chromium.org,ager@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 9 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-03 11:53:17 UTC) #1
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-03 11:56:59 UTC) #2
Mads Ager (chromium)
lgtm2
6 years, 6 months ago (2014-06-03 12:00:30 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-03 12:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/309283002/1
6 years, 6 months ago (2014-06-03 12:03:08 UTC) #5
haraken
LGTM
6 years, 6 months ago (2014-06-03 12:05:32 UTC) #6
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-03 12:55:50 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-03 14:42:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/309283002/1
6 years, 6 months ago (2014-06-03 14:43:17 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 15:22:22 UTC) #10
Message was sent while issue was closed.
Change committed as 175378

Powered by Google App Engine
This is Rietveld 408576698