Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309263002: Add browser test for VOLUME_TYPE_MTP volumes on Files.app. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add browser test for VOLUME_TYPE_MTP volumes on Files.app. BUG=263517 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274791

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -11 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 6 chunks +46 lines, -11 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/background.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/file_display.js View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinaba
6 years, 6 months ago (2014-06-03 08:41:36 UTC) #1
hirono
https://codereview.chromium.org/309263002/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/309263002/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode717 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:717: mtp_volume_->PrepareTestEntries(profile()); Should we check the result of PrepareTestEntries?
6 years, 6 months ago (2014-06-03 10:15:38 UTC) #2
kinaba
https://codereview.chromium.org/309263002/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right): https://codereview.chromium.org/309263002/diff/1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc#newcode717 chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:717: mtp_volume_->PrepareTestEntries(profile()); On 2014/06/03 10:15:39, hirono wrote: > Should we ...
6 years, 6 months ago (2014-06-04 01:50:53 UTC) #3
hirono
lgtm!
6 years, 6 months ago (2014-06-04 03:16:46 UTC) #4
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-04 03:21:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/309263002/20001
6 years, 6 months ago (2014-06-04 03:23:41 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 05:08:17 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 12:34:04 UTC) #8
Message was sent while issue was closed. 
Change committed as 274791

Powered by Google App Engine
This is Rietveld 408576698