Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 309253003: Move system_libdir to a deeper variable dict to fix issue 369119 (Closed)

Created:
6 years, 6 months ago by Alexander Potapenko
Modified:
6 years, 6 months ago
Reviewers:
vapier
CC:
chromium-reviews
Visibility:
Public.

Description

Move system_libdir to a deeper variable dict to fix issue 369119 (system_libdir being undefined in third_party/harfbuzz-ng/harfbuzz.gyp) BUG=369119 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/common.gypi View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
Nico, can you please take a look? I do not fully understand why this fixes ...
6 years, 6 months ago (2014-06-03 10:38:03 UTC) #1
Nico
Probably makes more sense if the folks who added system_libdir look at this?
6 years, 6 months ago (2014-06-03 14:11:37 UTC) #2
Alexander Potapenko
Agreed. Mike, can you please take a look?
6 years, 6 months ago (2014-06-03 14:23:37 UTC) #3
vapier
lgtm lgtm
6 years, 6 months ago (2014-06-03 19:24:43 UTC) #4
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 6 months ago (2014-06-03 19:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/309253003/1
6 years, 6 months ago (2014-06-03 19:54:17 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 00:17:14 UTC) #7
Message was sent while issue was closed.
Change committed as 274680

Powered by Google App Engine
This is Rietveld 408576698