Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 309253002: [SyncFS] SyncWorker cache refresh token status (Closed)

Created:
6 years, 6 months ago by peria
Modified:
6 years, 6 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] SyncWorker caches a flag if it has refresh token. BUG=347425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274844

Patch Set 1 #

Patch Set 2 : Remove unused methods #

Patch Set 3 : Rename #

Total comments: 2

Patch Set 4 : Rename again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 1 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 6 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
peria
PTL
6 years, 6 months ago (2014-06-03 09:37:49 UTC) #1
peria
ping?
6 years, 6 months ago (2014-06-04 04:43:39 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/309253002/diff/60001/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc (right): https://codereview.chromium.org/309253002/diff/60001/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc#newcode158 chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:158: void UpdateRefreshTokenStatus(bool set) { (optional) SetHasRefreshToken() looks more ...
6 years, 6 months ago (2014-06-04 05:04:53 UTC) #3
peria
https://codereview.chromium.org/309253002/diff/60001/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc (right): https://codereview.chromium.org/309253002/diff/60001/chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc#newcode158 chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:158: void UpdateRefreshTokenStatus(bool set) { On 2014/06/04 05:04:52, nhiroki wrote: ...
6 years, 6 months ago (2014-06-04 05:29:47 UTC) #4
tzik
lgtm
6 years, 6 months ago (2014-06-04 07:14:25 UTC) #5
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-04 07:15:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/309253002/80001
6 years, 6 months ago (2014-06-04 07:16:54 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 15:59:32 UTC) #8
Message was sent while issue was closed.
Change committed as 274844

Powered by Google App Engine
This is Rietveld 408576698