Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 309233002: Make navigator.serviceWorker.ready resolve with the controller. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
michaeln
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Make navigator.serviceWorker.ready resolve with the controller. The specification for ready is here: https://github.com/slightlyoff/ServiceWorker/issues/223 ready is a convenience that lets the page talk to an installed ServiceWorker, without having to track the details of whether that Service Worker is controlling the page, or merely installed but waiting for the page to reload. This implements the trivial ready case, where the page is controlled by a Service Worker and ready can produce that one immediately. BUG=363967 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175486

Patch Set 1 #

Patch Set 2 : Rename whenReady to ready and bring to head. #

Patch Set 3 : Baselines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -14 lines) Patch
A + LayoutTests/http/tests/serviceworker/ready-controlled-document.html View 1 2 chunks +13 lines, -9 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/ready-controlled-document-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/virtual/serviceworker/http/tests/serviceworker/ready-controlled-document-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 chunks +14 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dominicc (has gone to gerrit)
PTAL This relies on https://codereview.chromium.org/309503014/ going first so that == used by the test works. ...
6 years, 6 months ago (2014-06-03 06:35:45 UTC) #1
michaeln
lgtm fyi, there's discussion about changing the method to a property, please see github.
6 years, 6 months ago (2014-06-03 23:35:55 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 00:58:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/309233002/20001
6 years, 6 months ago (2014-06-04 00:59:33 UTC) #4
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 01:57:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/309233002/40001
6 years, 6 months ago (2014-06-04 01:57:35 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 03:23:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 03:26:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/10879)
6 years, 6 months ago (2014-06-04 03:26:11 UTC) #9
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 12:09:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/309233002/40001
6 years, 6 months ago (2014-06-04 12:10:50 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 13:05:26 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 14:27:08 UTC) #13
Message was sent while issue was closed.
Change committed as 175486

Powered by Google App Engine
This is Rietveld 408576698