Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 309203002: Fix the appearance of Views BlueButtons with GTK theming. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina, benwells
Visibility:
Public.

Description

ABANDONED IN FAVOR OF https://codereview.chromium.org/288983010 Fix the appearance of Views BlueButtons with GTK theming. BlueButton instances are using the GTK borders. This makes their white text illegible. Use the non-GTK blue button image assets instead. Related cleanup; before/after: http://crbug.com/375350#c2 BUG=375350 TEST=Views blue buttons look as expected. R=erg@chromium.org,estade@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M ui/views/controls/button/blue_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Elliot and Evan, please take a look; thanks! Ben, you may care about this, ...
6 years, 6 months ago (2014-06-03 02:15:21 UTC) #1
Evan Stade
Can you post a screenshot of the payments dialog in GTK theme mode with high ...
6 years, 6 months ago (2014-06-03 02:17:51 UTC) #2
msw
On 2014/06/03 02:17:51, Evan Stade wrote: > Can you post a screenshot of the payments ...
6 years, 6 months ago (2014-06-03 02:58:45 UTC) #3
Evan Stade
On 2014/06/03 02:58:45, msw wrote: > On 2014/06/03 02:17:51, Evan Stade wrote: > > Can ...
6 years, 6 months ago (2014-06-03 21:56:21 UTC) #4
msw
6 years, 6 months ago (2014-06-03 22:21:31 UTC) #5
On 2014/06/03 21:56:21, Evan Stade wrote:
> On 2014/06/03 02:58:45, msw wrote:
> > On 2014/06/03 02:17:51, Evan Stade wrote:
> > > Can you post a screenshot of the payments dialog in GTK theme mode with
high
> > > contrast inverse theme applied?
> > 
> > Done, see bug.
> 
> yep, 375350_payments_after.png looks bad because the blue button is the wrong
> size and flat instead of 3d. 375350_payments_inverse_after.png looks bad
because
> of the size and the color.
> 
> I think this patch is the wrong approach.

Abandoned.

Powered by Google App Engine
This is Rietveld 408576698