Issue 3092007: Delete chrome/browser/page_state.*.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3092007: Delete chrome/browser/page_state.*. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by viettrungluu

Modified:
3 years, 11 months ago

Reviewers:
Mohamed Mansour

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

Delete chrome/browser/page_state.*. There are exactly zero references to them. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55025

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -176 lines)			Patch
D	chrome/browser/page_state.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	chrome/browser/page_state.cc	View	1 chunk	+0 lines, -111 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Trybot results: win linux mac

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour

4 years, 10 months ago (2010-08-05 03:29:53 UTC) #1

LGTM, this class was never used. If in any case someone wants it back, they can
revive it. We currently use different ways to store navigation states.

Expand Messages | Collapse Messages