Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 309173003: Add arity checks to mjsunit's assertEquals and assertSame (Closed)

Created:
6 years, 6 months ago by arv (Not doing code reviews)
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add arity checks to mjsunit's assertEquals and assertSame BUG=None LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21748

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Add test #

Patch Set 4 : Remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M test/mjsunit/mjsunit.js View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
arv (Not doing code reviews)
Fix typo
6 years, 6 months ago (2014-06-03 00:40:58 UTC) #1
arv (Not doing code reviews)
PTAL
6 years, 6 months ago (2014-06-03 00:41:43 UTC) #2
arv (Not doing code reviews)
Add test
6 years, 6 months ago (2014-06-03 01:13:10 UTC) #3
arv (Not doing code reviews)
PTAL
6 years, 6 months ago (2014-06-09 21:50:17 UTC) #4
Michael Starzinger
Somehow it feels like overkill to have a test case for the sanity check in ...
6 years, 6 months ago (2014-06-10 11:59:37 UTC) #5
Michael Starzinger
LGTM (independent of how my previous comment is addressed).
6 years, 6 months ago (2014-06-10 12:05:19 UTC) #6
arv (Not doing code reviews)
On 2014/06/10 12:05:19, Michael Starzinger wrote: > LGTM (independent of how my previous comment is ...
6 years, 6 months ago (2014-06-10 14:37:32 UTC) #7
arv (Not doing code reviews)
Remove test
6 years, 6 months ago (2014-06-10 14:43:33 UTC) #8
arv (Not doing code reviews)
Uploaded new patch. Can you commit this for me when you have the time?
6 years, 6 months ago (2014-06-10 14:44:11 UTC) #9
Michael Starzinger
6 years, 6 months ago (2014-06-10 15:19:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r21748 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698