Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309173002: Delete NOTIFICATION_EXTENSION_LOCATION_BAR_UPDATED, never Notify()d. (Closed)

Created:
6 years, 6 months ago by not at google - send to devlin
Modified:
6 years, 6 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, tfarina, sky
Visibility:
Public.

Description

Delete NOTIFICATION_EXTENSION_LOCATION_BAR_UPDATED, never Notify()d. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
not at google - send to devlin
6 years, 6 months ago (2014-06-02 23:51:03 UTC) #1
Finnur
LGTM
6 years, 6 months ago (2014-06-03 00:00:05 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-06-03 00:00:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/309173002/1
6 years, 6 months ago (2014-06-03 00:01:31 UTC) #4
not at google - send to devlin
going to need an owner for this actually... sky@ mind reviewing? simple cleanup.
6 years, 6 months ago (2014-06-03 00:01:40 UTC) #5
not at google - send to devlin
6 years, 6 months ago (2014-06-03 00:01:52 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 04:15:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 04:17:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71234)
6 years, 6 months ago (2014-06-03 04:17:26 UTC) #9
sky
LGTM
6 years, 6 months ago (2014-06-03 16:00:16 UTC) #10
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-06-03 16:02:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/309173002/1
6 years, 6 months ago (2014-06-03 16:03:14 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 16:06:37 UTC) #13
Message was sent while issue was closed. 
Change committed as 274543

Powered by Google App Engine
This is Rietveld 408576698