Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309113003: TrayNotificationView: Initialize uninitialized member in constructor. (Closed)

Created:
6 years, 6 months ago by Finnur
Modified:
6 years, 6 months ago
Reviewers:
stevenjb, Jun Mukai
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

TrayNotificationView: Initialize uninitialized member in constructor. BUG=None CID=115769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/system/tray/tray_notification_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Finnur
6 years, 6 months ago (2014-06-02 22:30:32 UTC) #1
Jun Mukai
lgtm
6 years, 6 months ago (2014-06-02 22:37:09 UTC) #2
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 6 months ago (2014-06-02 23:04:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/309113003/1
6 years, 6 months ago (2014-06-02 23:05:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 02:15:24 UTC) #5
Finnur
Steven, mind doing an OWNERS check?
6 years, 6 months ago (2014-06-03 02:17:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 02:19:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71223)
6 years, 6 months ago (2014-06-03 02:19:27 UTC) #8
stevenjb
lgtm
6 years, 6 months ago (2014-06-03 15:36:44 UTC) #9
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 6 months ago (2014-06-03 17:33:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/309113003/1
6 years, 6 months ago (2014-06-03 17:34:49 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 17:39:25 UTC) #12
Message was sent while issue was closed. 
Change committed as 274564

Powered by Google App Engine
This is Rietveld 408576698