Make the system tray icons display when using KDE4 and plasma

Make the system tray icons display when using KDE4 and plasma

BUG=362880
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274444

[pkotwicz, 2014-06-02 18:41:58]

Elliot, can you please take a look?

https://codereview.chromium.org/309103002/diff/20001/chrome/browser/ui/libgtk...
File chrome/browser/ui/libgtk2ui/app_indicator_icon.cc (right):

https://codereview.chromium.org/309103002/diff/20001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon.cc:133: return !using_kde4;
Creating a temporary directory per icon causes problems on KDE4. I have not
chased down why.

https://codereview.chromium.org/309103002/diff/20001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon.cc:142: //
"/usr/share/icons/hicolor/16x16/apps" exists.
KDE5 (which uses QIconLoader instead of KIconLoader for system tray icons) is
much more reasonable thankfully and parses the index.theme file in the directory
passed into app_indicator_set_icon_theme_path(). On KDE5 the index.theme file is
cached but not across runs of Chrome.

https://codereview.chromium.org/309103002/diff/20001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon.cc:150: const
scoped_refptr<base::RefCountedMemory>& png_data) {
sni-qt (https://launchpad.net/sni-qt) seems to do the same thing

I haven't found any docs as to how to properly clear KDE's icon cache.
KGlobalSettings::emitChange() was the closest I found.

[Elliot Glaysher, 2014-06-02 20:06:04]

lgtm

https://codereview.chromium.org/309103002/diff/20001/chrome/browser/ui/libgtk...
File chrome/browser/ui/libgtk2ui/app_indicator_icon.cc (right):

https://codereview.chromium.org/309103002/diff/20001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon.cc:152: // Chrome.
Is this comment correct? The following seems to make a content addressable
resource; the same icon will have the same file name across runs.

[pkotwicz, 2014-06-02 21:22:41]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-06-02 21:25:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/309103002/80001

[commit-bot: I haz the power, 2014-06-03 03:30:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-03 09:07:26]

Change committed as 274444