Source/core/rendering/compositing/CompositedLayerMapping.cpp - Issue 309093002: Issue repaints before and after changing the squashing assignment of a RenderLayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 309093002: Issue repaints before and after changing the squashing assignment of a RenderLayer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix logic. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/compositing/squashing/squash-above-fixed-1-expected.txt ('K') | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | Source/core/rendering/compositing/CompositingLayerAssigner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp

diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp

index 3f3eeb5bc620195b3bcd7e04d5f38dbf2058e7f6..38d719bd38f782bc97e01799741a936219085495 100644

--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp

+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp

@@ -2175,10 +2175,12 @@ bool CompositedLayerMapping::updateSquashingLayerAssignment(RenderLayer* squashe

bool updatedAssignment = false;

if (nextSquashedLayerIndex < m_squashedLayers.size()) {

if (!paintInfo.isEquivalentForSquashing(m_squashedLayers[nextSquashedLayerIndex])) {

+ compositor()->repaintOnCompositingChange(squashedLayer);

updatedAssignment = true;

m_squashedLayers[nextSquashedLayerIndex] = paintInfo;

}

} else {

+ compositor()->repaintOnCompositingChange(squashedLayer);

m_squashedLayers.append(paintInfo);

updatedAssignment = true;

}