Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: LayoutTests/compositing/squashing/add-remove-squashed-layers-expected.txt

Issue 309093002: Issue repaints before and after changing the squashing assignment of a RenderLayer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix logic. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 Test that layers can be nicely added or removed from a squashed layer, without u nnecessary repaints on any layer. Click anywhere to test interactively; keep cli cking to proceed through the test. 1 Test that layers can be nicely added or removed from a squashed layer, without u nnecessary repaints on any layer. Click anywhere to test interactively; keep cli cking to proceed through the test.
2 2
3 CASE 1, original layer tree with overlap1 and overlap2: 3 CASE 1, original layer tree with overlap1 and overlap2:
4 (GraphicsLayer 4 (GraphicsLayer
5 (bounds 800.00 600.00) 5 (bounds 800.00 600.00)
6 (children 1 6 (children 1
7 (GraphicsLayer 7 (GraphicsLayer
8 (bounds 800.00 600.00) 8 (bounds 800.00 600.00)
9 (contentsOpaque 1) 9 (contentsOpaque 1)
10 (drawsContent 1) 10 (drawsContent 1)
(...skipping 21 matching lines...) Expand all
32 CASE 2, overlap3 gets added: 32 CASE 2, overlap3 gets added:
33 (GraphicsLayer 33 (GraphicsLayer
34 (bounds 800.00 600.00) 34 (bounds 800.00 600.00)
35 (children 1 35 (children 1
36 (GraphicsLayer 36 (GraphicsLayer
37 (bounds 800.00 600.00) 37 (bounds 800.00 600.00)
38 (contentsOpaque 1) 38 (contentsOpaque 1)
39 (drawsContent 1) 39 (drawsContent 1)
40 (repaint rects 40 (repaint rects
41 (rect 300.00 300.00 100.00 100.00) 41 (rect 300.00 300.00 100.00 100.00)
42 (rect 300.00 300.00 100.00 100.00)
chrishtr 2014/06/02 20:16:24 Repaint for overlap3 when getting added to the squ
42 ) 43 )
43 (children 1 44 (children 1
44 (GraphicsLayer 45 (GraphicsLayer
45 (children 2 46 (children 2
46 (GraphicsLayer 47 (GraphicsLayer
47 (position 60.00 60.00) 48 (position 60.00 60.00)
48 (bounds 400.00 400.00) 49 (bounds 400.00 400.00)
49 (contentsOpaque 1) 50 (contentsOpaque 1)
50 (drawsContent 1) 51 (drawsContent 1)
51 (backgroundColor #808080) 52 (backgroundColor #808080)
52 ) 53 )
53 (GraphicsLayer 54 (GraphicsLayer
54 (position 140.00 140.00) 55 (position 140.00 140.00)
55 (bounds 260.00 260.00) 56 (bounds 260.00 260.00)
56 (drawsContent 1) 57 (drawsContent 1)
57 (repaint rects 58 (repaint rects
59 (rect 160.00 160.00 20.00 20.00)
chrishtr 2014/06/02 20:16:24 The actual rect generated is (160 160 260 60), aft
58 (rect 140.00 140.00 40.00 40.00) 60 (rect 140.00 140.00 40.00 40.00)
59 (rect 80.00 80.00 100.00 100.00) 61 (rect 80.00 80.00 100.00 100.00)
60 (rect 0.00 0.00 100.00 100.00) 62 (rect 0.00 0.00 100.00 100.00)
61 (rect 0.00 0.00 100.00 100.00)
62 ) 63 )
63 ) 64 )
64 ) 65 )
65 ) 66 )
66 ) 67 )
67 ) 68 )
68 ) 69 )
69 ) 70 )
70 CASE 3, overlap2 gets removed. Since this does not resize the layer, there shoul d only be a repaint of overlap2: 71 CASE 3, overlap2 gets removed. Since this does not resize the layer, there shoul d only be a repaint of overlap2:
71 (GraphicsLayer 72 (GraphicsLayer
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 CASE 5, overlap2 gets added back: 136 CASE 5, overlap2 gets added back:
136 (GraphicsLayer 137 (GraphicsLayer
137 (bounds 800.00 600.00) 138 (bounds 800.00 600.00)
138 (children 1 139 (children 1
139 (GraphicsLayer 140 (GraphicsLayer
140 (bounds 800.00 600.00) 141 (bounds 800.00 600.00)
141 (contentsOpaque 1) 142 (contentsOpaque 1)
142 (drawsContent 1) 143 (drawsContent 1)
143 (repaint rects 144 (repaint rects
144 (rect 220.00 220.00 100.00 100.00) 145 (rect 220.00 220.00 100.00 100.00)
146 (rect 220.00 220.00 100.00 100.00)
chrishtr 2014/06/02 20:16:24 This and the ones below are the same situation as
145 ) 147 )
146 (children 1 148 (children 1
147 (GraphicsLayer 149 (GraphicsLayer
148 (children 2 150 (children 2
149 (GraphicsLayer 151 (GraphicsLayer
150 (position 60.00 60.00) 152 (position 60.00 60.00)
151 (bounds 400.00 400.00) 153 (bounds 400.00 400.00)
152 (contentsOpaque 1) 154 (contentsOpaque 1)
153 (drawsContent 1) 155 (drawsContent 1)
154 (backgroundColor #808080) 156 (backgroundColor #808080)
155 ) 157 )
156 (GraphicsLayer 158 (GraphicsLayer
157 (position 220.00 220.00) 159 (position 220.00 220.00)
158 (bounds 180.00 180.00) 160 (bounds 180.00 180.00)
159 (drawsContent 1) 161 (drawsContent 1)
160 (repaint rects 162 (repaint rects
161 (rect 0.00 0.00 100.00 100.00) 163 (rect 0.00 0.00 100.00 100.00)
162 (rect 0.00 0.00 100.00 100.00) 164 (rect 0.00 0.00 100.00 100.00)
163 (rect 0.00 0.00 100.00 100.00) 165 (rect 0.00 0.00 100.00 100.00)
166 (rect 0.00 0.00 20.00 20.00)
164 ) 167 )
165 ) 168 )
166 ) 169 )
167 ) 170 )
168 ) 171 )
169 ) 172 )
170 ) 173 )
171 ) 174 )
172 CASE 6, overlap1 gets added back, and overlap3 gets removed: 175 CASE 6, overlap1 gets added back, and overlap3 gets removed:
173 (GraphicsLayer 176 (GraphicsLayer
174 (bounds 800.00 600.00) 177 (bounds 800.00 600.00)
175 (children 1 178 (children 1
176 (GraphicsLayer 179 (GraphicsLayer
177 (bounds 800.00 600.00) 180 (bounds 800.00 600.00)
178 (contentsOpaque 1) 181 (contentsOpaque 1)
179 (drawsContent 1) 182 (drawsContent 1)
180 (repaint rects 183 (repaint rects
181 (rect 140.00 140.00 100.00 100.00) 184 (rect 140.00 140.00 100.00 100.00)
185 (rect 140.00 140.00 100.00 100.00)
182 ) 186 )
183 (children 1 187 (children 1
184 (GraphicsLayer 188 (GraphicsLayer
185 (children 2 189 (children 2
186 (GraphicsLayer 190 (GraphicsLayer
187 (position 60.00 60.00) 191 (position 60.00 60.00)
188 (bounds 400.00 400.00) 192 (bounds 400.00 400.00)
189 (contentsOpaque 1) 193 (contentsOpaque 1)
190 (drawsContent 1) 194 (drawsContent 1)
191 (backgroundColor #808080) 195 (backgroundColor #808080)
192 ) 196 )
193 (GraphicsLayer 197 (GraphicsLayer
194 (position 140.00 140.00) 198 (position 140.00 140.00)
195 (bounds 180.00 180.00) 199 (bounds 180.00 180.00)
196 (drawsContent 1) 200 (drawsContent 1)
197 (repaint rects 201 (repaint rects
198 (rect 80.00 80.00 100.00 100.00) 202 (rect 80.00 80.00 100.00 100.00)
199 (rect 0.00 0.00 100.00 100.00) 203 (rect 0.00 0.00 100.00 100.00)
200 (rect 0.00 0.00 100.00 100.00) 204 (rect 0.00 0.00 100.00 100.00)
201 (rect 0.00 0.00 100.00 100.00) 205 (rect 0.00 0.00 100.00 100.00)
202 (rect 0.00 0.00 20.00 20.00) 206 (rect 0.00 0.00 20.00 20.00)
207 (rect 0.00 0.00 20.00 20.00)
203 ) 208 )
204 ) 209 )
205 ) 210 )
206 ) 211 )
207 ) 212 )
208 ) 213 )
209 ) 214 )
210 ) 215 )
211 216
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698