components/autofill/content/renderer/form_autofill_util.cc - Issue 309063006: Do not autofill element when there is no autofill suggestion from profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 309063006: Do not autofill element when there is no autofill suggestion from profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per further review comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/request_autocomplete_manager.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_autofill_util.cc

diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc

index 0762a8c2f42d63453203996698864f515690072f..46852f2fbfba8457562ea1f63a333f8977436389 100644

--- a/components/autofill/content/renderer/form_autofill_util.cc

+++ b/components/autofill/content/renderer/form_autofill_util.cc

@@ -537,6 +537,9 @@ void FillFormField(const FormFieldData& data,

if (data.value.empty())

return;

+ if (!data.is_autofilled)

+ return;

field->setAutofilled(true);

WebInputElement* input_element = toWebInputElement(field);

@@ -571,6 +574,9 @@ void PreviewFormField(const FormFieldData& data,

if (data.value.empty())

return;

+ if (!data.is_autofilled)

+ return;

// Preview input, textarea and select fields. For input fields, excludes

// checkboxes and radio buttons, as there is no provision for

// setSuggestedCheckedValue in WebInputElement.