Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 309063006: Do not autofill element when there is no autofill suggestion from profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per Ilya's review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index bfb8d492ca0e0cdfd936c8c9095c1ad72184f021..0ed5aa0223b389074a505a2a9f40399cf3813889 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -557,6 +557,9 @@ void AutofillManager::FillOrPreviewForm(
// Mark the cached field as autofilled, so that we can detect when a
// user edits an autofilled field (for metrics).
form_structure->field(i)->is_autofilled = true;
Ilya Sherman 2014/06/03 20:39:31 nit: Please leave a blank line after this one.
+ // Mark the field as autofilled when a non-empty value is assigned to
+ // it.
Ilya Sherman 2014/06/03 20:39:31 nit: Please extend this comment with "This allows
+ result.fields[i].is_autofilled = true;
if (should_notify)
manager_delegate_->DidFillOrPreviewField(value, profile_full_name);

Powered by Google App Engine
This is Rietveld 408576698