Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 309013006: Add quic_types.h and move the typedefs unrelated to the QUIC protocol (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add quic_types.h and move the typedefs unrelated to the QUIC protocol specification from quic_protocol.h to quic_types.h. Add the QuicAsyncStatus enum type (to quic_types.h), which represents the return status of asynchronous operations. Replace ProofVerifier::Status with QuicAsyncStatus. Moved typedefs unrelated to the QUIC protocol specification from quic_protocol.h to the new quic_types.h header. Replaced ProofVerifier::Status with the new general-purpose QuicAsyncStatus enum type. Merge internal change: 68267420 R=rch@chromium.org, wtc@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -130 lines) Patch
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/crypto/proof_verifier.h View 2 chunks +13 lines, -21 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 1 chunk +9 lines, -8 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 9 chunks +21 lines, -20 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -37 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +0 lines, -23 lines 0 comments Download
A net/quic/quic_types.h View 1 chunk +69 lines, -0 lines 0 comments Download
A net/quic/quic_types.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_socket_utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-02 20:05:47 UTC) #1
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-02 22:41:29 UTC) #2
wtc
Patch set 1 LGTM.
6 years, 6 months ago (2014-06-02 22:48:20 UTC) #3
ramant (doing other things)
6 years, 6 months ago (2014-06-02 23:49:17 UTC) #4 
On 2014/06/02 22:48:20, wtc wrote:
> Patch set 1 LGTM.

Thanks very much Ryan and Wan-Teh
raman

Powered by Google App Engine
This is Rietveld 408576698