DevTools: Event listener breakpoint should not stop if happened inside framework.

Source/bindings/v8/ScriptDebugServer.cpp

 /*
  * Copyright (c) 2010-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 150 matching lines @@
     ensureDebuggerScriptCompiled();
     v8::HandleScope scope(m_isolate);
     v8::Context::Scope contextScope(v8::Debug::GetDebugContext());
 
     v8::Handle<v8::Value> argv[] = { v8::Int32::New(m_isolate, pauseOnExceptionsState) };
     callDebuggerMethod("setPauseOnExceptionsState", 1, argv);
 }
 
 void ScriptDebugServer::setPauseOnNextStatement(bool pause)
 {
-    if (isPaused())
-        return;
+    ASSERT(!isPaused());
     if (pause)
         v8::Debug::DebugBreak(m_isolate);
     else
         v8::Debug::CancelDebugBreak(m_isolate);
 }
 
 bool ScriptDebugServer::canBreakProgram()
 {
     if (!m_breakpointsActivated)
         return false;
@@ skipping 124 matching lines @@
             *error = toCoreStringWithUndefinedOrNullCheck(resultTuple->Get(1));
             errorData = TypeBuilder::Debugger::SetScriptSourceError::create();
             errorData->setCompileError(compileError);
             return false;
         }
     }
     *error = "Unknown error.";
     return false;
 }
 
+int ScriptDebugServer::frameCount()
+{
+    v8::Handle<v8::Value> result;
+    if (m_executionState.IsEmpty()) {
+        v8::Handle<v8::Function> frameCountFunction = v8::Local<v8::Function>::Cast(m_debuggerScript.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "frameCount")));

[yurys, 2014/06/03 13:19:43]

AFAIU this branch is unused so I'd rather put an ASSERT that we are paused.

[aandrey, 2014/06/04 08:51:27]

Done.

+        result = v8::Debug::Call(frameCountFunction);
+    } else {
+        v8::Handle<v8::Value> argv[] = { m_executionState };
+        result = callDebuggerMethod("frameCount", WTF_ARRAY_LENGTH(argv), argv);
+    }
+    if (result->IsInt32())
+        return result->Int32Value();
+    return 0;
+}
+
 PassRefPtr<JavaScriptCallFrame> ScriptDebugServer::wrapCallFrames(int maximumLimit, ScopeInfoDetails scopeDetails)
 {
     const int scopeBits = 2;
     COMPILE_ASSERT(NoScopes < (1 << scopeBits), not_enough_bits_to_encode_ScopeInfoDetails);
 
     ASSERT(maximumLimit >= 0);
     int data = (maximumLimit << scopeBits) | scopeDetails;
     v8::Handle<v8::Value> currentCallFrameV8;
     if (m_executionState.IsEmpty()) {
         v8::Handle<v8::Function> currentCallFrameFunction = v8::Local<v8::Function>::Cast(m_debuggerScript.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "currentCallFrame")));
@@ skipping 291 matching lines @@
 {
     return PassOwnPtr<ScriptSourceCode>();
 }
 
 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& source, const String& url, const String& functionName)
 {
     return source;
 }
 
 } // namespace WebCore