Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 309013004: Added more logging (Closed)

Created:
6 years, 6 months ago by Sergiy Byelozyorov
Modified:
6 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M scripts/master/try_job_rietveld.py View 1 2 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergiy Byelozyorov
6 years, 6 months ago (2014-06-02 13:40:49 UTC) #1
Paweł Hajdan Jr.
LGTM with comments. https://codereview.chromium.org/309013004/diff/20001/scripts/master/try_job_rietveld.py File scripts/master/try_job_rietveld.py (right): https://codereview.chromium.org/309013004/diff/20001/scripts/master/try_job_rietveld.py#newcode329 scripts/master/try_job_rietveld.py:329: if len(new_processed_keys): nit: No need to ...
6 years, 6 months ago (2014-06-02 13:45:47 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/309013004/diff/20001/scripts/master/try_job_rietveld.py File scripts/master/try_job_rietveld.py (right): https://codereview.chromium.org/309013004/diff/20001/scripts/master/try_job_rietveld.py#newcode329 scripts/master/try_job_rietveld.py:329: if len(new_processed_keys): On 2014/06/02 13:45:47, Paweł Hajdan Jr. wrote: ...
6 years, 6 months ago (2014-06-02 13:52:27 UTC) #3
Sergiy Byelozyorov
The CQ bit was checked by sergiyb@chromium.org
6 years, 6 months ago (2014-06-02 13:52:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/309013004/40001
6 years, 6 months ago (2014-06-02 13:52:52 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 13:53:49 UTC) #6
Message was sent while issue was closed.
Change committed as 274227

Powered by Google App Engine
This is Rietveld 408576698