Issue 308963006: Convert Sync BirthdayErrorTest to use FakeServer

Issue 308963006: Convert Sync BirthdayErrorTest to use FakeServer (Closed)

Created:
6 years, 6 months ago by pval...(no longer on Chromium)

Modified:
6 years, 6 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Convert Sync BirthdayErrorTest to use FakeServer BUG=323265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274459

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -48 lines)			Patch
M	chrome/browser/sync/test/integration/sync_errors_test.cc	View		6 chunks	+18 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/test/integration/sync_test.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/test/integration/sync_test.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	sync/test/fake_server/fake_server.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	sync/test/fake_server/fake_server.cc	View	1	4 chunks	+41 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM https://codereview.chromium.org/308963006/diff/20001/sync/test/fake_server/fake_server.cc File sync/test/fake_server/fake_server.cc (right): https://codereview.chromium.org/308963006/diff/20001/sync/test/fake_server/fake_server.cc#newcode228 sync/test/fake_server/fake_server.cc:228: bool success; nit: initialize to false

6 years, 6 months ago (2014-06-02 22:02:04 UTC) #2

pval...(no longer on Chromium)

https://codereview.chromium.org/308963006/diff/20001/sync/test/fake_server/fake_server.cc File sync/test/fake_server/fake_server.cc (right): https://codereview.chromium.org/308963006/diff/20001/sync/test/fake_server/fake_server.cc#newcode228 sync/test/fake_server/fake_server.cc:228: bool success; On 2014/06/02 22:02:04, Nicolas Zea wrote: > ...

6 years, 6 months ago (2014-06-02 23:06:54 UTC) #3

pval...(no longer on Chromium)

The CQ bit was checked by pvalenzuela@chromium.org

6 years, 6 months ago (2014-06-02 23:06:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/308963006/40001

6 years, 6 months ago (2014-06-02 23:08:16 UTC) #5

Message was sent while issue was closed.

Change committed as 274459

Expand Messages | Collapse Messages