Source/core/inspector/InspectorController.cpp - Issue 308963002: Minimize calls to Node::nodeType() as it is virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorController.cpp

Issue 308963002: Minimize calls to Node::nodeType() as it is virtual (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix typo Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorController.cpp

diff --git a/Source/core/inspector/InspectorController.cpp b/Source/core/inspector/InspectorController.cpp

index 93fb08161d9b11297b7ebe9a75bff565b149ca3f..5cdc9776936f8dbd2572d0f29592ada2716b1e05 100644

--- a/Source/core/inspector/InspectorController.cpp

+++ b/Source/core/inspector/InspectorController.cpp

@@ -311,7 +311,7 @@ void InspectorController::inspect(Node* node)

if (!frame)

return;

- if (node->nodeType() != Node::ELEMENT_NODE && node->nodeType() != Node::DOCUMENT_NODE)

+ if (!node->isElementNode() && !node->isDocumentNode())

node = node->parentNode();

InjectedScript injectedScript = m_injectedScriptManager->injectedScriptFor(ScriptState::forMainWorld(frame));