Source/core/dom/Range.cpp - Issue 308963002: Minimize calls to Node::nodeType() as it is virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.cpp

Issue 308963002: Minimize calls to Node::nodeType() as it is virtual (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix typo Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Range.cpp

diff --git a/Source/core/dom/Range.cpp b/Source/core/dom/Range.cpp

index 9189f403bbb65bda280a75d7fa493fb648135f57..8208db20b812596323b1bc7a981b61b45cfe07c0 100644

--- a/Source/core/dom/Range.cpp

+++ b/Source/core/dom/Range.cpp

@@ -951,7 +951,8 @@ String Range::toString() const

Node* pastLast = pastLastNode();

for (Node* n = firstNode(); n != pastLast; n = NodeTraversal::next(*n)) {

- if (n->nodeType() == Node::TEXT_NODE || n->nodeType() == Node::CDATA_SECTION_NODE) {

+ Node::NodeType type = n->nodeType();

+ if (type == Node::TEXT_NODE || type == Node::CDATA_SECTION_NODE) {

String data = toCharacterData(n)->data();

int length = data.length();

int start = (n == m_start.container()) ? min(max(0, m_start.offset()), length) : 0;