Minimize calls to Node::nodeType() as it is virtual

Source/core/xml/XPathStep.cpp

 /*
  * Copyright (C) 2005 Frerich Raabe <raabe@kde.org>
  * Copyright (C) 2006, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 148 matching lines @@
         default:
             return Node::ELEMENT_NODE;
     }
 }
 #endif
 
 // Evaluate NodeTest without considering merged predicates.
 static inline bool nodeMatchesBasicTest(Node* node, Step::Axis axis, const Step::NodeTest& nodeTest)
 {
     switch (nodeTest.kind()) {
-        case Step::NodeTest::TextNodeTest:
-            return node->nodeType() == Node::TEXT_NODE || node->nodeType() == Node::CDATA_SECTION_NODE;
+        case Step::NodeTest::TextNodeTest: {
+            Node::NodeType type = node->nodeType();
+            return type == Node::TEXT_NODE || type == Node::CDATA_SECTION_NODE;
+        }
         case Step::NodeTest::CommentNodeTest:
             return node->nodeType() == Node::COMMENT_NODE;
         case Step::NodeTest::ProcessingInstructionNodeTest: {
             const AtomicString& name = nodeTest.data();
             return node->nodeType() == Node::PROCESSING_INSTRUCTION_NODE && (name.isEmpty() || node->nodeName() == name);
         }
         case Step::NodeTest::AnyNodeTest:
             return true;
         case Step::NodeTest::NameTest: {
             const AtomicString& name = nodeTest.data();
@@ skipping 10 matching lines @@
                     return namespaceURI.isEmpty() || node->namespaceURI() == namespaceURI;
 
                 return node->localName() == name && node->namespaceURI() == namespaceURI;
             }
 
             // Node test on the namespace axis is not implemented yet, the caller has a check for it.
             ASSERT(axis != Step::NamespaceAxis);
 
             // For other axes, the principal node type is element.
             ASSERT(primaryNodeType(axis) == Node::ELEMENT_NODE);
-            if (node->nodeType() != Node::ELEMENT_NODE)
+            if (!node->isElementNode())
                 return false;
+            Element& element = toElement(*node);
 
             if (name == starAtom)
-                return namespaceURI.isEmpty() || namespaceURI == node->namespaceURI();
+                return namespaceURI.isEmpty() || namespaceURI == element.namespaceURI();
 
-            if (node->document().isHTMLDocument()) {
-                if (node->isHTMLElement()) {
+            if (element.document().isHTMLDocument()) {
+                if (element.isHTMLElement()) {
                     // Paths without namespaces should match HTML elements in HTML documents despite those having an XHTML namespace. Names are compared case-insensitively.
-                    return equalIgnoringCase(toElement(node)->localName(), name) && (namespaceURI.isNull() || namespaceURI == node->namespaceURI());
+                    return equalIgnoringCase(element.localName(), name) && (namespaceURI.isNull() || namespaceURI == element.namespaceURI());
                 }
                 // An expression without any prefix shouldn't match no-namespace nodes (because HTML5 says so).
-                return toElement(node)->hasLocalName(name) && namespaceURI == node->namespaceURI() && !namespaceURI.isNull();
+                return element.hasLocalName(name) && namespaceURI == element.namespaceURI() && !namespaceURI.isNull();
             }
-            return toElement(node)->hasLocalName(name) && namespaceURI == node->namespaceURI();
+            return element.hasLocalName(name) && namespaceURI == element.namespaceURI();
         }
     }
     ASSERT_NOT_REACHED();
     return false;
 }
 
 static inline bool nodeMatches(Node* node, Step::Axis axis, const Step::NodeTest& nodeTest)
 {
     if (!nodeMatchesBasicTest(node, axis, nodeTest))
         return false;
@@ skipping 173 matching lines @@
             nodes.markSorted(false);
             return;
         }
     }
     ASSERT_NOT_REACHED();
 }
 
 
 }
 }