Issue 308943002: Reset margin input controls error state when error is cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308943002: Reset margin input controls error state when error is cleared. (Closed)

Created:
6 years, 6 months ago by Aleksey Shlyapnikov

Modified:
6 years, 6 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reset margin input controls error state when error is cleared. Fix aria warnings for the same controls. Reset margin input controls error state when error is cleared. Fix aria warnings for the same controls. BUG=354340 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274454

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -65 lines)			Patch
M	chrome/browser/resources/print_preview/previewarea/margin_control.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/print_preview/previewarea/margin_control.js	View	10 chunks	+38 lines, -64 lines	0 comments	Download
M	chrome/browser/resources/print_preview/previewarea/margin_control_container.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/test/data/webui/print_preview.js	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/308943002/1

6 years, 6 months ago (2014-06-02 22:37:42 UTC) #3

Message was sent while issue was closed.

Change committed as 274454

Expand Messages | Collapse Messages