Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 308933002: Fix PassphraseTextfield::OnFocus (Closed)

Created:
6 years, 6 months ago by stevenjb
Modified:
6 years, 6 months ago
Reviewers:
msw, kevers
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, josafat1, oshima, Shu Chen, Yuki
Visibility:
Public.

Description

Fix PassphraseTextfield::OnFocus A changed to Textfield broke OnFocus/OnBlur behavior of PassphraseTextfield. This provides an expedient fix until the class is deprecated completely. BUG=378914 TBR=kevers@chromium.org, msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/options/passphrase_textfield.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
I'm going to run this through the CQ so we get it in over the ...
6 years, 6 months ago (2014-05-30 23:54:44 UTC) #1
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 6 months ago (2014-05-30 23:54:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/308933002/1
6 years, 6 months ago (2014-05-31 00:00:46 UTC) #3
msw
I guess this lgtm, but really, this should be reviewed by Shu Chen, Oshima, and ...
6 years, 6 months ago (2014-05-31 00:19:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-31 05:04:14 UTC) #5
commit-bot: I haz the power
Change committed as 274076
6 years, 6 months ago (2014-05-31 22:35:47 UTC) #6
stevenjb
6 years, 6 months ago (2014-06-02 15:14:15 UTC) #7
Message was sent while issue was closed.
On 2014/05/31 00:19:08, msw wrote:
> I guess this lgtm, but really, this should be reviewed by Shu Chen, Oshima,
and
> Kevers (the offending r270818 author and reviewers), and perhaps Yuki (for
input
> method interaction). Also, it'd be nice if this textfield sublass were
removed,
> since it doesn't seem to do much more than set the text on a password
Textfield
> to some placeholder.

I'm working hard to deprecate the network connect dialogs and this class
entirely.

Powered by Google App Engine
This is Rietveld 408576698