Issue 308913006: Cleanup: Style fixes in extensions/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308913006: Cleanup: Style fixes in extensions/browser (Closed)

Created:
6 years, 6 months ago by Yeun

Modified:
6 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Cleanup: Style fixes in extensions/browser 1) Fix Namespace comment in admin_policy.h 2) Mark explicit to single-argument constructors in file_highlighter.h and test_extensions_browser_client.h 3) Use CHECK_GT instead of CHECK in process_manager.cc BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274475

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	extensions/browser/admin_policy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/file_highlighter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/process_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/test_extensions_browser_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/308913006/1

6 years, 6 months ago (2014-06-03 00:39:55 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...

6 years, 6 months ago (2014-06-03 04:42:19 UTC) #5

Message was sent while issue was closed.

Change committed as 274475

Expand Messages | Collapse Messages