Issue 308913004: cros: Expose client_id via chromeosInfoPrivate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308913004: cros: Expose client_id via chromeosInfoPrivate. (Closed)

Created:
6 years, 6 months ago by xiyuan

Modified:
6 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome, zel

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cros: Expose client_id via chromeosInfoPrivate. Expose client_id in chromeosInforPrivate for enterprise kiosk. BUG=328437 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274313

Patch Set 1 #

Patch Set 2 : remove sn since not working #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
M	chrome/browser/chromeos/extensions/info_private_api.cc	View	1	4 chunks	+25 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/chromeos_info_private.json	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/chromeos_info_private/background.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/308913004/10001

6 years, 6 months ago (2014-06-02 17:04:31 UTC) #4

asargent_no_longer_on_chrome

lgtm assuming you've done any necessary privacy review

6 years, 6 months ago (2014-06-02 17:17:45 UTC) #6

Message was sent while issue was closed.

Change committed as 274313

Expand Messages | Collapse Messages