Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 308913002: Build gtest for both 'host' and 'target'. (Closed)

Created:
6 years, 6 months ago by simonb (inactive)
Modified:
6 years, 6 months ago
Reviewers:
simonb1, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Build gtest for both 'host' and 'target'. The (future) relocation packing tool requires a host build of gtest for its unit tests. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/gtest.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
simonb (inactive)
6 years, 6 months ago (2014-05-30 17:15:01 UTC) #1
rmcilroy
lgtm, thanks.
6 years, 6 months ago (2014-05-30 17:18:56 UTC) #2
simonb1
The CQ bit was checked by simonb@google.com
6 years, 6 months ago (2014-06-02 12:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/308913002/1
6 years, 6 months ago (2014-06-02 12:02:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 13:43:25 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 15:57:35 UTC) #6
Message was sent while issue was closed.
Change committed as 274251

Powered by Google App Engine
This is Rietveld 408576698