Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 308903002: Add webview:partitions usage to webview documentation (Closed)

Created:
6 years, 6 months ago by Mark Dittmer
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add webview:partitions usage to webview documentation We currently implement a manifest configuration option: { ... webview: { partitions: { ... } } }, but it is undocumented. This change adds it to the introductory sections of the webview tag documentation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274668

Patch Set 1 #

Total comments: 15

Patch Set 2 : Rewrite of resources-packaged-within-app documentation in response to code review comments #

Total comments: 21

Patch Set 3 : Added partition name pattern example to <webview>: "accessing packaged resources" documentation. Al… #

Patch Set 4 : Link to partition subsection from packaged resources description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/intros/webview_tag.html View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Mark Dittmer
6 years, 6 months ago (2014-05-30 16:29:39 UTC) #1
fsamuel
I love it! Thanks Mark!
6 years, 6 months ago (2014-05-30 16:46:52 UTC) #2
Fady Samuel
lgtm
6 years, 6 months ago (2014-05-30 17:14:25 UTC) #3
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 6 months ago (2014-05-30 18:13:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/308903002/1
6 years, 6 months ago (2014-05-30 18:16:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 23:20:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 23:35:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70802)
6 years, 6 months ago (2014-05-30 23:35:28 UTC) #8
Mark Dittmer
Hey Ben, I'm Fady's intern this summer. I need an owner code review for this ...
6 years, 6 months ago (2014-06-02 14:00:41 UTC) #9
not at google - send to devlin
https://codereview.chromium.org/308903002/diff/1/chrome/common/extensions/docs/templates/intros/webview_tag.html File chrome/common/extensions/docs/templates/intros/webview_tag.html (right): https://codereview.chromium.org/308903002/diff/1/chrome/common/extensions/docs/templates/intros/webview_tag.html#newcode134 chrome/common/extensions/docs/templates/intros/webview_tag.html:134: <h2 id="local_resources">Accessing package-local resources</h2> what does "package-local" mean? (rhetorical) ...
6 years, 6 months ago (2014-06-02 17:00:18 UTC) #10
Mark Dittmer
Addressed most comments. Still unsure as to whether the example code should be more abstract ...
6 years, 6 months ago (2014-06-02 18:39:50 UTC) #11
fsamuel
https://codereview.chromium.org/308903002/diff/10001/chrome/common/extensions/docs/templates/intros/webview_tag.html File chrome/common/extensions/docs/templates/intros/webview_tag.html (right): https://codereview.chromium.org/308903002/diff/10001/chrome/common/extensions/docs/templates/intros/webview_tag.html#newcode158 chrome/common/extensions/docs/templates/intros/webview_tag.html:158: name: "static", Partitions can also have patterns. It might ...
6 years, 6 months ago (2014-06-02 18:45:18 UTC) #12
not at google - send to devlin
https://codereview.chromium.org/308903002/diff/1/chrome/common/extensions/docs/templates/intros/webview_tag.html File chrome/common/extensions/docs/templates/intros/webview_tag.html (right): https://codereview.chromium.org/308903002/diff/1/chrome/common/extensions/docs/templates/intros/webview_tag.html#newcode134 chrome/common/extensions/docs/templates/intros/webview_tag.html:134: <h2 id="local_resources">Accessing package-local resources</h2> On 2014/06/02 18:39:51, Mark Dittmer ...
6 years, 6 months ago (2014-06-02 18:54:10 UTC) #13
Mark Dittmer
Addressed all comments except the "accessible_resources":[] comment. https://codereview.chromium.org/308903002/diff/10001/chrome/common/extensions/docs/templates/intros/webview_tag.html File chrome/common/extensions/docs/templates/intros/webview_tag.html (right): https://codereview.chromium.org/308903002/diff/10001/chrome/common/extensions/docs/templates/intros/webview_tag.html#newcode134 chrome/common/extensions/docs/templates/intros/webview_tag.html:134: <h2 id="local_resources">Accessing ...
6 years, 6 months ago (2014-06-03 11:34:50 UTC) #14
not at google - send to devlin
lgtm https://codereview.chromium.org/308903002/diff/10001/chrome/common/extensions/docs/templates/intros/webview_tag.html File chrome/common/extensions/docs/templates/intros/webview_tag.html (right): https://codereview.chromium.org/308903002/diff/10001/chrome/common/extensions/docs/templates/intros/webview_tag.html#newcode161 chrome/common/extensions/docs/templates/intros/webview_tag.html:161: // Webviews with partition "trusted" or "persist:trusted" may ...
6 years, 6 months ago (2014-06-03 18:17:37 UTC) #15
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 6 months ago (2014-06-03 18:25:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/308903002/50001
6 years, 6 months ago (2014-06-03 18:27:18 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 23:24:41 UTC) #18
Message was sent while issue was closed.
Change committed as 274668

Powered by Google App Engine
This is Rietveld 408576698