Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 308883003: Revert of TSAN caught us racing in ScalarBench.cpp (Closed)

Created:
6 years, 6 months ago by mtklein
Modified:
6 years, 6 months ago
Reviewers:
mtklein_C, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of TSAN caught us racing in ScalarBench.cpp (https://codereview.chromium.org/305033002/) Reason for revert: windows doesn't like it Original issue's description: > TSAN caught us racing in ScalarBench.cpp > > http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14992 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M bench/ScalarBench.cpp View 3 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of TSAN caught us racing in ScalarBench.cpp
6 years, 6 months ago (2014-05-30 15:09:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/308883003/1
6 years, 6 months ago (2014-05-30 15:09:39 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 15:09:45 UTC) #3
Message was sent while issue was closed. 
Change committed as 14994

Powered by Google App Engine
This is Rietveld 408576698