tools/perf/benchmarks/benchmark_unittest.py - Issue 308843002: [Telemetry] Re-enable the benchmark smoke test on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_unittest.py

Issue 308843002: [Telemetry] Re-enable the benchmark smoke test on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_unittest.py b/tools/perf/benchmarks/benchmark_unittest.py

index f1e0eef9dd057b7ad198cbed58bb01dfa02ef6b6..0018610ea749b371a245658da14c7aefc65669c5 100644

--- a/tools/perf/benchmarks/benchmark_unittest.py

+++ b/tools/perf/benchmarks/benchmark_unittest.py

@@ -22,7 +22,7 @@ def SmokeTestGenerator(benchmark):

# In general you should @test.Disabled individual benchmarks that fail,

# instead of this entire smoke test suite.

# TODO(achuith): Multiple tests failing on CrOS. crbug.com/351114

- @test.Disabled('android', 'chromeos', 'win')

+ @test.Disabled('android', 'chromeos')

def BenchmarkSmokeTest(self):

# Only measure a single page so that this test cycles reasonably quickly.

benchmark.options['pageset_repeat'] = 1

« no previous file with comments | « no previous file | no next file » | no next file with comments »