Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 308833004: use non-deprecated version of installPixels (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Visibility:
Public.

Description

use non-deprecated version of installPixels Allows skia to remove SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS NOTRY=True failures unrelated to this CL Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
reed1
6 years, 6 months ago (2014-05-30 21:37:42 UTC) #1
reed1
linux failure is unrelated
6 years, 6 months ago (2014-05-31 00:02:06 UTC) #2
f(malita)
lgtm
6 years, 6 months ago (2014-05-31 00:35:16 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-02 18:13:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/308833004/1
6 years, 6 months ago (2014-06-02 18:14:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 21:03:31 UTC) #6
reed1
The CQ bit was unchecked by reed@google.com
6 years, 6 months ago (2014-06-02 21:04:50 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-02 21:04:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/308833004/1
6 years, 6 months ago (2014-06-02 21:05:59 UTC) #9
reed1
The CQ bit was unchecked by reed@google.com
6 years, 6 months ago (2014-06-02 21:16:50 UTC) #10
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-02 21:16:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/308833004/1
6 years, 6 months ago (2014-06-02 21:18:13 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:24:16 UTC) #13
Message was sent while issue was closed.
Change committed as 274337

Powered by Google App Engine
This is Rietveld 408576698