Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 308803002: Change type of interface created by mojo:view_manager (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Change type of interface created by mojo:view_manager It now creates a IViewManagerInit, which has the single method Connect to connect to the route. As suggested I disabled all the view_manager_lib_unittests until they are converted to new connection logic. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273812

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+840 lines, -981 lines) Patch
M mojo/mojo_services.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 14 chunks +16 lines, -14 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/services/view_manager/main.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 4 chunks +13 lines, -1 line 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 3 chunks +24 lines, -8 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
A mojo/services/view_manager/root_view_manager_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 3 chunks +9 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 27 chunks +572 lines, -920 lines 0 comments Download
A mojo/services/view_manager/view_manager_init_connection.h View 1 1 chunk +79 lines, -0 lines 0 comments Download
A mojo/services/view_manager/view_manager_init_connection.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M mojo/shell/view_manager_loader.h View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/shell/view_manager_loader.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 6 months ago (2014-05-30 02:26:00 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-05-30 05:07:35 UTC) #2
sky
6 years, 6 months ago (2014-05-30 13:07:30 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r273812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698