Issue 308793012: Inline fast path for Array.indexOf() and Array.lastIndexOf().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308793012: Inline fast path for Array.indexOf() and Array.lastIndexOf(). (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer

Modified:
6 years, 6 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline fast path for Array.indexOf() and Array.lastIndexOf(). TEST=mjsunit/array-indexing R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21617

Patch Set 2 : Handle heap numbers correctly #

Patch Set 3 : HOptimizedGraphBuilder::BuildArrayIndexOf() #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -18 lines)			Patch
M	src/hydrogen.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	2 chunks	+179 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2	1 chunk	+20 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Benedikt, very nice. Just one stylistic comment. --Michael https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc#newcode8063 src/hydrogen.cc:8063: ...

6 years, 6 months ago (2014-06-02 11:43:44 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc#newcode8063 src/hydrogen.cc:8063: { Done.

6 years, 6 months ago (2014-06-02 12:08:15 UTC) #3