Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 308793003: SVG: Add comment to |loopbreaker| local static var that it is safe (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Visibility:
Public.

Description

SVG: Add comment to |loopbreaker| local static var that it is safe This is a follow up CL to https://codereview.chromium.org/305783004/ BUG=357163 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175093

Patch Set 1 #

Total comments: 2

Patch Set 2 : haraken #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/svg/animation/SVGSMILElement.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
rubberstamp plz
6 years, 6 months ago (2014-05-30 01:38:07 UTC) #1
haraken
LGTM https://codereview.chromium.org/308793003/diff/1/Source/core/svg/animation/SVGSMILElement.cpp File Source/core/svg/animation/SVGSMILElement.cpp (right): https://codereview.chromium.org/308793003/diff/1/Source/core/svg/animation/SVGSMILElement.cpp#newcode1250 Source/core/svg/animation/SVGSMILElement.cpp:1250: // |loopbreaker| is used to avoid infinite recursions ...
6 years, 6 months ago (2014-05-30 01:39:45 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-05-30 01:51:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/308793003/20001
6 years, 6 months ago (2014-05-30 01:53:00 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 01:53:57 UTC) #5
Message was sent while issue was closed.
Change committed as 175093

Powered by Google App Engine
This is Rietveld 408576698