Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: apps/shell/browser/shell_browser_main_parts.cc

Issue 308783002: Removes the dependency to WMTestHelper from app shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/shell/browser/shell_browser_main_parts.h" 5 #include "apps/shell/browser/shell_browser_main_parts.h"
6 6
7 #include "apps/shell/browser/shell_browser_context.h" 7 #include "apps/shell/browser/shell_browser_context.h"
8 #include "apps/shell/browser/shell_browser_main_delegate.h" 8 #include "apps/shell/browser/shell_browser_main_delegate.h"
9 #include "apps/shell/browser/shell_desktop_controller.h" 9 #include "apps/shell/browser/shell_desktop_controller.h"
10 #include "apps/shell/browser/shell_extension_system.h" 10 #include "apps/shell/browser/shell_extension_system.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 // TODO(jamescook): Initialize chromeos::CrosSettings here? 74 // TODO(jamescook): Initialize chromeos::CrosSettings here?
75 75
76 // Return no error. 76 // Return no error.
77 return 0; 77 return 0;
78 } 78 }
79 79
80 void ShellBrowserMainParts::PreMainMessageLoopRun() { 80 void ShellBrowserMainParts::PreMainMessageLoopRun() {
81 // Initialize our "profile" equivalent. 81 // Initialize our "profile" equivalent.
82 browser_context_.reset(new ShellBrowserContext); 82 browser_context_.reset(new ShellBrowserContext);
83 83
84 desktop_controller_.reset(new ShellDesktopController); 84 desktop_controller_.reset(browser_main_delegate_->CreateDesktopController());
85 desktop_controller_->GetWindowTreeHost()->AddObserver(this); 85 desktop_controller_->CreateRootWindow();
86 desktop_controller_->host()->AddObserver(this);
86 87
87 // NOTE: Much of this is culled from chrome/test/base/chrome_test_suite.cc 88 // NOTE: Much of this is culled from chrome/test/base/chrome_test_suite.cc
88 // TODO(jamescook): Initialize chromeos::UserManager. 89 // TODO(jamescook): Initialize chromeos::UserManager.
89 net_log_.reset(new content::ShellNetLog("app_shell")); 90 net_log_.reset(new content::ShellNetLog("app_shell"));
90 91
91 extensions_client_.reset(new ShellExtensionsClient()); 92 extensions_client_.reset(new ShellExtensionsClient());
92 extensions::ExtensionsClient::Set(extensions_client_.get()); 93 extensions::ExtensionsClient::Set(extensions_client_.get());
93 94
94 extensions_browser_client_.reset( 95 extensions_browser_client_.reset(
95 new extensions::ShellExtensionsBrowserClient(browser_context_.get())); 96 new extensions::ShellExtensionsBrowserClient(browser_context_.get()));
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 void ShellBrowserMainParts::PostMainMessageLoopRun() { 130 void ShellBrowserMainParts::PostMainMessageLoopRun() {
130 browser_main_delegate_->Shutdown(); 131 browser_main_delegate_->Shutdown();
131 132
132 BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices( 133 BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices(
133 browser_context_.get()); 134 browser_context_.get());
134 extension_system_ = NULL; 135 extension_system_ = NULL;
135 extensions::ExtensionsBrowserClient::Set(NULL); 136 extensions::ExtensionsBrowserClient::Set(NULL);
136 extensions_browser_client_.reset(); 137 extensions_browser_client_.reset();
137 browser_context_.reset(); 138 browser_context_.reset();
138 139
139 desktop_controller_->GetWindowTreeHost()->RemoveObserver(this); 140 desktop_controller_->host()->RemoveObserver(this);
140 desktop_controller_.reset(); 141 desktop_controller_.reset();
141 } 142 }
142 143
143 void ShellBrowserMainParts::PostDestroyThreads() { 144 void ShellBrowserMainParts::PostDestroyThreads() {
144 #if defined(OS_CHROMEOS) 145 #if defined(OS_CHROMEOS)
145 network_controller_.reset(); 146 network_controller_.reset();
146 chromeos::DBusThreadManager::Shutdown(); 147 chromeos::DBusThreadManager::Shutdown();
147 #endif 148 #endif
148 } 149 }
149 150
150 void ShellBrowserMainParts::OnHostCloseRequested( 151 void ShellBrowserMainParts::OnHostCloseRequested(
151 const aura::WindowTreeHost* host) { 152 const aura::WindowTreeHost* host) {
152 desktop_controller_->CloseAppWindow(); 153 desktop_controller_->CloseAppWindow();
153 base::MessageLoop::current()->PostTask(FROM_HERE, 154 base::MessageLoop::current()->PostTask(FROM_HERE,
154 base::MessageLoop::QuitClosure()); 155 base::MessageLoop::QuitClosure());
oshima 2014/05/29 23:06:59 Can't you move this code into DesktopController? T
Jun Mukai 2014/05/29 23:26:44 I am not sure I'm following. Do you mean that han
Jun Mukai 2014/05/30 00:59:03 Updated. I think I've done what you're saing, PTAL
155 } 156 }
156 157
157 void ShellBrowserMainParts::CreateExtensionSystem() { 158 void ShellBrowserMainParts::CreateExtensionSystem() {
158 DCHECK(browser_context_); 159 DCHECK(browser_context_);
159 extension_system_ = static_cast<ShellExtensionSystem*>( 160 extension_system_ = static_cast<ShellExtensionSystem*>(
160 ExtensionSystem::Get(browser_context_.get())); 161 ExtensionSystem::Get(browser_context_.get()));
161 extension_system_->InitForRegularProfile(true); 162 extension_system_->InitForRegularProfile(true);
162 } 163 }
163 164
164 } // namespace apps 165 } // namespace apps
OLDNEW
« no previous file with comments | « apps/shell/browser/shell_browser_main_delegate.h ('k') | apps/shell/browser/shell_desktop_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698