Issue 308773007: Merge 273573 "Always call talk_base::InitializeSSL() in chromoti..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308773007: Merge 273573 "Always call talk_base::InitializeSSL() in chromoti..." (Closed)

Created:
6 years, 6 months ago by Sergey Ulanov

Modified:
6 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

Merge 273573 "Always call talk_base::InitializeSSL() in chromoti..." > Always call talk_base::InitializeSSL() in chromoting plugin. > > crrev.com/272789 added talk_base::InitializeSSL() under USE_NSS ifdef, > but it didn't work because USE_NSS is not defined on Windows and Mac > even when NSS is actually used (duh!). (USE_NSS is used for X509 certs > and Windows and Mac don't use NSS for X509 certs). > > BUG=364689 > TBR=jamiewalch@chromium.org > > Review URL: https://codereview.chromium.org/307813003 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274100

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	remoting/client/plugin/chromoting_instance.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Sergey Ulanov

6 years, 6 months ago (2014-06-01 00:49:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r274100 (tree was closed).